On 2012/05/14 20:53:41, Vyacheslav Egorov wrote:
LGTM
I recommend passing test with FLAG_collect_maps forces to false on all
architectures before committing.
If you run the test suite with FLAG_collect_maps set to false by default,
you
only get the obvious failures:
* cctest/test-heap/LeakGlobalContextViaMapProto
* cctest/test-heap/PrototypeTransitionClearing
* cctest/test-heap/Regress1465
I don't think it makes sense to mask away these failures when map
collection is
disabled, since they perfectly indicate what goes wrong when you disable it.
Besides the above failures, the test suite runs through (on ia32, x64 and
ARM).
https://chromiumcodereview.appspot.com/10386046/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
