Reviewers: Yang,
Description:
Add a readbuffer function to d8, that reads a file into an ArrayBuffer.
[email protected]
BUG=
TEST=
Please review this at https://chromiumcodereview.appspot.com/10388139/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
src/d8.h
src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
edd201bbdf1f2d40474a999160c4f5d568443ff2..adbe5501368e20b412a028b910854bf84d8b87b1
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -835,6 +835,8 @@ Handle<ObjectTemplate> Shell::CreateGlobalTemplate() {
global_template->Set(String::New("read"), FunctionTemplate::New(Read));
global_template->Set(String::New("readbinary"),
FunctionTemplate::New(ReadBinary));
+ global_template->Set(String::New("readbuffer"),
+ FunctionTemplate::New(ReadBuffer));
global_template->Set(String::New("readline"),
FunctionTemplate::New(ReadLine));
global_template->Set(String::New("load"), FunctionTemplate::New(Load));
@@ -1070,6 +1072,32 @@ Handle<Value> Shell::ReadBinary(const Arguments&
args) {
}
+Handle<Value> Shell::ReadBuffer(const Arguments& args) {
+ String::Utf8Value filename(args[0]);
+ int length;
+ if (*filename == NULL) {
+ return ThrowException(String::New("Error loading file"));
+ }
+ char* data = ReadChars(*filename, &length);
+ if (data == NULL) {
+ return ThrowException(String::New("Error reading file"));
+ }
+
+ Handle<Object> buffer = Object::New();
+ buffer->Set(String::New(kArrayBufferMarkerPropName), True(), ReadOnly);
+
+ Persistent<Object> persistent_buffer = Persistent<Object>::New(buffer);
+ persistent_buffer.MakeWeak(data, ExternalArrayWeakCallback);
+ persistent_buffer.MarkIndependent();
+
+ buffer->SetIndexedPropertiesToExternalArrayData(
+ reinterpret_cast<uint8_t*>(data), kExternalUnsignedByteArray,
length);
+ buffer->Set(String::New("byteLength"),
+ Int32::New(static_cast<int32_t>(length)), ReadOnly);
+ return buffer;
+}
+
+
#ifndef V8_SHARED
static char* ReadToken(char* data, char token) {
char* next = i::OS::StrChr(data, token);
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index
c872f90958f48d16d21d1de86d694fa560bfe11d..23fdebcaf4043c018e49fc95d183ebe19c89cef8
100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -308,6 +308,7 @@ class Shell : public i::AllStatic {
static Handle<Value> DisableProfiler(const Arguments& args);
static Handle<Value> Read(const Arguments& args);
static Handle<Value> ReadBinary(const Arguments& args);
+ static Handle<Value> ReadBuffer(const Arguments& args);
static Handle<String> ReadFromStdin();
static Handle<Value> ReadLine(const Arguments& args) {
return ReadFromStdin();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
