LGTM (with two comments).
https://chromiumcodereview.appspot.com/10387130/diff/1/src/builtins.cc File src/builtins.cc (right): https://chromiumcodereview.appspot.com/10387130/diff/1/src/builtins.cc#newcode420 src/builtins.cc:420: if (maybe_transition->IsFailure()) return maybe_transition; At this point we know that the array has FAST_ELEMENTS, so we could early return with array->elements() as result. https://chromiumcodereview.appspot.com/10387130/diff/1/src/builtins.cc#newcode422 src/builtins.cc:422: if (args == NULL) { Can we merge that into line 415 like the following? That would make behavior consistent between FAST_DOUBLE_ELEMENTS and other FAST_FOOBAR_ELEMENTS. And it would also be consistent with the copy-on-write case below. if (args == NULL || array->HasFastElements()) return elms; https://chromiumcodereview.appspot.com/10387130/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
