Reviewers: Mads Sig Ager, Søren Thygesen Gjesse, Description: Define V8_EXPORT to nothing for clients of v8.
This is to make sure that inline functions are only exported by libv8.so and not also by all clients. This is the v8 version of https://chromiumcodereview.appspot.com/10386108/ This CL depends on http://codereview.chromium.org/10310156/ landing first. BUG=chromium:90078 Please review this at https://chromiumcodereview.appspot.com/10399036/ SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M include/v8.h Index: include/v8.h =================================================================== --- include/v8.h (revision 11566) +++ include/v8.h (working copy) @@ -66,7 +66,11 @@ // between building or using the V8 shared library, but we should not // export symbols when we are building a static library. #if defined(__GNUC__) && (__GNUC__ >= 4) && defined(V8_SHARED) +#ifdef BUILDING_V8_SHARED #define V8EXPORT __attribute__ ((visibility("default"))) +#else +#define V8EXPORT +#endif #else // defined(__GNUC__) && (__GNUC__ >= 4) #define V8EXPORT #endif // defined(__GNUC__) && (__GNUC__ >= 4) -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
