Reviewers: rossberg,
Description:
Merged r11140 into 3.9 branch.
Fix the return type of the date set methods.
Original CL: https://chromiumcodereview.appspot.com/9809010
[email protected]
BUG=V8:2027,128315,120086
TEST=test/mjsunit/regress/regress-2027.js
Please review this at https://chromiumcodereview.appspot.com/10391162/
SVN Base: https://v8.googlecode.com/svn/branches/3.9
Affected files:
M src/date.js
M src/runtime.cc
M src/version.cc
A test/mjsunit/regress/regress-2027.js
Index: src/date.js
diff --git a/src/date.js b/src/date.js
index
75edf6d32d17c364023c39cb319c937c1421286d..d0e24abc503eb21124a430dc981ed17fe767d010
100644
--- a/src/date.js
+++ b/src/date.js
@@ -516,8 +516,7 @@ function DateSetMilliseconds(ms) {
var t = LOCAL_DATE_VALUE(this);
ms = ToNumber(ms);
var time = MakeTime(LOCAL_HOUR(this), LOCAL_MIN(this), LOCAL_SEC(this),
ms);
- SET_LOCAL_DATE_VALUE(this, MakeDate(LOCAL_DAYS(this), time));
- return this;
+ return SET_LOCAL_DATE_VALUE(this, MakeDate(LOCAL_DAYS(this), time));
}
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
77c1cd8da90cc22aaa1e3b8f7ee363fe7b5ab126..6a24f988c1a3b01eeb59beba709108b98fb92c50
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -7582,7 +7582,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_DateSetValue) {
}
}
date->SetValue(value, is_value_nan);
- return *date;
+ return value;
}
Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index
fa5f4c7e75f477e7eb1cdf962868d52fb60711d9..37c2ec262b9ce1327d6a2f14398bda1e87e961ad
100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 9
#define BUILD_NUMBER 24
-#define PATCH_LEVEL 24
+#define PATCH_LEVEL 25
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
Index: test/mjsunit/regress/regress-2027.js
diff --git a/test/mjsunit/regress/regress-2027.js
b/test/mjsunit/regress/regress-2027.js
new file mode 100644
index
0000000000000000000000000000000000000000..00ed03f650cd8e8f4d4c494761d70b9141b454db
--- /dev/null
+++ b/test/mjsunit/regress/regress-2027.js
@@ -0,0 +1,48 @@
+// Copyright 2012 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+var d = new Date(2010, 1, 1);
+
+function Check(time) {
+ assertEquals(d.getTime(), time);
+}
+
+Check(d.setMilliseconds(10));
+Check(d.setSeconds(10));
+Check(d.setMinutes(10));
+Check(d.setHours(10));
+Check(d.setDate(10));
+Check(d.setMonth(10));
+Check(d.setFullYear(2010));
+Check(d.setUTCMilliseconds(10));
+Check(d.setUTCSeconds(10));
+Check(d.setUTCMinutes(10));
+Check(d.setUTCHours(10));
+Check(d.setUTCDate(10));
+Check(d.setUTCMonth(10));
+Check(d.setUTCFullYear(2010));
+
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
