On 2012/05/15 13:55:46, Jakob wrote:
GYP changes LGTM.
Yang (thanks!) said he'd test if the defines changes cause any breakage on Windows.
It turns out d8 does not like having USING_V8_SHARED and V8_SHARED set at the same time. I fixed that in http://codereview.chromium.org/10398057/ and landed
it in r11586. http://codereview.chromium.org/10310156/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
