Revision: 11590
Author:   [email protected]
Date:     Fri May 18 02:52:09 2012
Log:      Define V8_EXPORT to nothing for clients of v8.

This is to make sure that inline functions are only exported by
libv8.so and not also by all clients. This is the v8 version of
https://chromiumcodereview.appspot.com/10386108/

This CL depends on http://codereview.chromium.org/10310156/ landing
first.

BUG=chromium:90078

Review URL: https://chromiumcodereview.appspot.com/10399036
http://code.google.com/p/v8/source/detail?r=11590

Modified:
 /branches/bleeding_edge/include/v8.h

=======================================
--- /branches/bleeding_edge/include/v8.h        Wed Apr 25 01:45:45 2012
+++ /branches/bleeding_edge/include/v8.h        Fri May 18 02:52:09 2012
@@ -62,11 +62,13 @@

 #else  // _WIN32

-// Setup for Linux shared library export. There is no need to distinguish
-// between building or using the V8 shared library, but we should not
-// export symbols when we are building a static library.
+// Setup for Linux shared library export.
 #if defined(__GNUC__) && (__GNUC__ >= 4) && defined(V8_SHARED)
+#ifdef BUILDING_V8_SHARED
 #define V8EXPORT __attribute__ ((visibility("default")))
+#else
+#define V8EXPORT
+#endif
 #else  // defined(__GNUC__) && (__GNUC__ >= 4)
 #define V8EXPORT
 #endif  // defined(__GNUC__) && (__GNUC__ >= 4)

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to