LGTM with comment. And maybe add a test?
https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc#newcode360 src/d8.cc:360: array->Set(String::New(kArrayBufferMarkerPropName), True(), ReadOnly); Is the property _is_array_buffer_ something that is supposed to be exposed? You could use SetHiddenValue instead. Same goes for _array_buffer_ref_. https://chromiumcodereview.appspot.com/10392130/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
