On Fri, May 18, 2012 at 2:54 AM, <[email protected]> wrote: > On 2012/05/18 09:48:52, Yang wrote: > >> On 2012/05/16 16:16:04, Nico wrote: >> > Thanks! >> > >> > The prerequisite landed in r11586 – could someone land this CL? >> > >> > http://codereview.chromium.**org/10399036/diff/1/include/**v8.h<http://codereview.chromium.org/10399036/diff/1/include/v8.h> >> > File include/v8.h (right): >> > >> > http://codereview.chromium.**org/10399036/diff/1/include/** >> v8.h#newcode65<http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65> >> > include/v8.h:65: // Setup for Linux shared library export. There is no >> need >> > to > >> > distinguish >> > On 2012/05/16 07:55:36, Mads Sig Ager wrote: >> > > Please update the comment as well. :) >> > >> > Done. >> > > I'll land this then. >> > > Landed as r11590.
Thanks! > Please base your future CLs on svn/bleeding_edge instead of > svn/trunk :) > Will do. Is there a wiki page somewhere that explains how to send out patches to v8 when using the v8 directory in a chromium checkout? I just did `cd v8; gcl change blah; gcl upload blah;`, and chromium seems to pull from svn/trunk. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
