LGTM (with one nit).
https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py#newcode511 tools/grokdump.py:511: def IsASCIIRegion(self, location, length): Maybe we should rename this to IsProbableASCIIRegion, because the determination isn't accurate, it's basically just guessing. https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py#newcode532 tools/grokdump.py:532: def IsExecutableRegion(self, location, length): Likewise. https://chromiumcodereview.appspot.com/10356150/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
