https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h File src/heap-inl.h (right):
https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h#newcode599 src/heap-inl.h:599: // TODO(yangguo): check that the object is indeed an external string. Can we use ASSERT(obj->IsExternalString()) and be done with this TODO or am I missing something? https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h#newcode609 src/heap-inl.h:609: // TODO(yangguo): check that the object is indeed an external string. Likewise. https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap.cc#newcode4501 src/heap.cc:4501: for (int i = 0; i < length; i++) { Can we use memset() here instead? https://chromiumcodereview.appspot.com/10407090/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
