https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh
File tools/fuzz-harness.sh (right):
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode40
tools/fuzz-harness.sh:40: jsfunfuzz_file=$v8_root/tools/jsfunfuzz.zip
On 2012/05/22 14:12:01, Jakob wrote:
Please put quotes around any variables containing paths outside this
script's
control. Someone might have spaces in their $v8_root path. (Several
more times
below.)
Done.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode46
tools/fuzz-harness.sh:46: jsfunfuzz_sum=$(md5sum $jsfunfuzz_file | awk
"{ print \$1 }")
On 2012/05/22 14:12:01, Jakob wrote:
nit: if you use single quotes, you don't need the backslash:
awk '{ print $1 }'
Done.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode63
tools/fuzz-harness.sh:63: $v8_root/d8_g $flags_debug
$jsfunfuzz_dir/jsfunfuzz/jsfunfuzz.js
On 2012/05/22 14:12:01, Jakob wrote:
You want this to work with the GYP build, don't you? So please don't
hard-code
the path to d8. You *could* implement auto-detection of a few fixed
locations,
but that's brittle. The easiest solution is probably to accept an
optional
parameter for the relative path to d8, similar to
http://code.google.com/p/v8/source/browse/branches/bleeding_edge/tools/check-static-initializers.sh#41
(and the next few lines).
Done. As discussed offline, I switched the script to only run against
one build (either debug or release) at a time. So it is in sync with our
other scripts.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode66
tools/fuzz-harness.sh:66: tar -cjf `date +%y%m%d`-debug.tar.bz2 err-* w*
On 2012/05/22 14:12:01, Jakob wrote:
Please use $(...) instead of `...`.
Done.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode67
tools/fuzz-harness.sh:67: rm err-* w*
On 2012/05/22 14:12:01, Jakob wrote:
Might want to use "rm -f" to suppress errors and interactivity. Just
in case.
(Same below.)
Done.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode72
tools/fuzz-harness.sh:72: $v8_root/d8 $flags_release
$jsfunfuzz_dir/jsfunfuzz/jsfunfuzz.js
On 2012/05/22 14:12:01, Jakob wrote:
Same request for dynamic/overridable path to d8 here.
Done.
https://chromiumcodereview.appspot.com/10407094/diff/1/tools/fuzz-harness.sh#newcode77
tools/fuzz-harness.sh:77: echo "Release failures: $exit_debug"
On 2012/05/22 14:12:01, Jakob wrote:
surely you mean $exit_release.
Done.
https://chromiumcodereview.appspot.com/10407094/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
