https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc#newcode1003 src/profile-generator.cc:1003: self_size(), id(), indent, ' ', prefix, edge_name); nit: extra space https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc#newcode3344 src/profile-generator.cc:3344: 6 * MaxDecimalDigitsIn<sizeof(int)>::kSigned // NOLINT 6 -> 4 https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc#newcode3346 src/profile-generator.cc:3346: + 7 + 1 + 1; 7 -> 5 https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.h#newcode487 src/profile-generator.h:487: int from_index_ : 29; Looks like we can kill from_index_ now. Isn't it? https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.h#newcode555 src/profile-generator.h:555: unsigned type_; make it a bit field with e.g. children_count_. This would allow us to save up to 8 bytes per entry on x64. https://chromiumcodereview.appspot.com/10416035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
