Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
Add explicit "python" to subprocess args in test wrapper script
Please review this at https://chromiumcodereview.appspot.com/10447031/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/test-wrapper-gypbuild.py
Index: tools/test-wrapper-gypbuild.py
diff --git a/tools/test-wrapper-gypbuild.py b/tools/test-wrapper-gypbuild.py
index
eda24591732ce14f3b93bc628d57a851a6989d96..27b5a3521de019bb1e020ef86912df70ff435879
100755
--- a/tools/test-wrapper-gypbuild.py
+++ b/tools/test-wrapper-gypbuild.py
@@ -224,7 +224,8 @@ def Main():
print ">>> running presubmit tests"
returncodes += subprocess.call([workspace + '/tools/presubmit.py'])
- args_for_children = [workspace + '/tools/test.py'] +
PassOnOptions(options)
+ args_for_children = ['python']
+ args_for_children += [workspace + '/tools/test.py'] +
PassOnOptions(options)
args_for_children += ['--no-build', '--build-system=gyp']
for arg in args:
args_for_children += [arg]
@@ -240,10 +241,14 @@ def Main():
shellpath = workspace + '/' + options.outdir + '/' + arch + '.' +
mode
env['LD_LIBRARY_PATH'] = shellpath + '/lib.target'
shell = shellpath + "/d8"
- child = subprocess.Popen(' '.join(args_for_children +
- ['--arch=' + arch] +
- ['--mode=' + mode] +
- ['--shell=' + shell]),
+ cmdline = ' '.join(args_for_children +
+ ['--arch=' + arch] +
+ ['--mode=' + mode] +
+ ['--shell=' + shell])
+ # TODO(jkummerow): This print is temporary.
+ print "Executing: %s" % cmdline
+
+ child = subprocess.Popen(cmdline,
shell=True,
cwd=workspace,
env=env)
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
