LGTM. Just one nit, can we change the sorting to sort all upper-case letters after lower-case ones? That would be consistent with our ".gitignore" files. I almost couldn't find the "Debug" entry.
Best regards, Michael On Fri, May 25, 2012 at 4:18 PM, Jakob Kummerow <[email protected]>wrote: > Reviewers: mstarzinger, > > Message: > Another CL containing svn:ignore updates. Please review by responding to > this mail. > > Description: > Update svn:ignore properties for Windows-specific directories that are not > part of the V8 checkout. > Move MSVS settings to the configuration-independent part of common.gypi > > SVN Base: https://v8.googlecode.com/svn > > > $ svn diff > > Property changes on: trunk > ___________________________________________________________________ > Modified: svn:ignore > - .cpplint-cache > obj > out > > > + .cpplint-cache > obj > out > third_party > > > > > Property changes on: trunk/build > ___________________________________________________________________ > Modified: svn:ignore > - gyp > > > + Debug > gyp > Release > > > > > Property changes on: branches/bleeding_edge > ___________________________________________________________________ > Modified: svn:ignore > - .cpplint-cache > .sconsign.dblite > obj > out > > + .cpplint-cache > .sconsign.dblite > obj > out > third_party > > > > Property changes on: branches/bleeding_edge/build > ___________________________________________________________________ > Modified: svn:ignore > - gyp > > > + Debug > gyp > Release > > > > Index: branches/bleeding_edge/build/common.gypi > =================================================================== > --- branches/bleeding_edge/build/common.gypi (revision 11666) > +++ branches/bleeding_edge/build/common.gypi (working copy) > @@ -238,6 +238,11 @@ > 'defines': [ > 'WIN32', > ], > + 'msvs_configuration_attributes': { > + 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', > + 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', > + 'CharacterSet': '1', > + }, > }], > ['OS=="win" and v8_enable_prof==1', { > 'msvs_settings': { > @@ -359,11 +364,6 @@ > }, > }], # OS=="mac" > ['OS=="win"', { > - 'msvs_configuration_attributes': { > - 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', > - 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', > - 'CharacterSet': '1', > - }, > 'msvs_settings': { > 'VCCLCompilerTool': { > 'Optimization': '2', > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
