LGTM with comments. Short ChangeLog entries FTW :-)
https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode3 ChangeLog:3: Fixed JSObject::SetPropertyForResult. (issue 2153) Don't need this (bug wasn't present in last trunk version, right?) https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode5 ChangeLog:5: Enabled map transitions for accessor properties. Don't need this (invisible to embedders, right?). https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode7 ChangeLog:7: Clear pending functions list in FuncNameInferrer when it closes. (issue 2146) nit: 80 columns. Also, I'd change the description to something more understandable, like "Fixed function name inference in a few cases". But then it's basically indistinguishable from the next entry. So we don't need this either. https://chromiumcodereview.appspot.com/10451065/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
