LGTM (if one comment and a few nits are addressed).
https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc#newcode1640 src/objects.cc:1640: object_function()->map()) { Indentation seems off. https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.h#newcode4869 src/objects.h:4869: Map* GetPrototypeTransition(Object* prototype); I know this is not part of this CL, but can we add some comments to [Get/Put]PrototypeTransition() and also briefly describe the new "the-hole magic" you are adding? https://chromiumcodereview.appspot.com/10448011/diff/12002/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://chromiumcodereview.appspot.com/10448011/diff/12002/test/cctest/test-heap.cc#newcode1592 test/cctest/test-heap.cc:1592: for (int i = 0; i < 10 - 3; i++) { The loop should also go to (11 - 3) ... better put that in a constant. https://chromiumcodereview.appspot.com/10448011/diff/12002/test/cctest/test-heap.cc#newcode1597 test/cctest/test-heap.cc:1597: CHECK(proto == trans->GetHeap()->the_hole_value() || proto->IsJSObject()); Can we just use proto->IsTheHole() here, that's more readable? https://chromiumcodereview.appspot.com/10448011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
