http://codereview.chromium.org/10443085/diff/1/src/api.cc File src/api.cc (right):
http://codereview.chromium.org/10443085/diff/1/src/api.cc#newcode1674 src/api.cc:1674: exception_(i::Smi::FromInt(0)), On 2012/05/31 08:48:52, ulan wrote:
Why is exception_ = 0 here, instead of the hole? try_catch.HasCaught() seems to be always true in mksnapshot.cc since
it checks
for the hole.
Well spotted. It turns out that I can just test the return value for IsEmpty and get rid of the ugly special TryCatch constructor. http://codereview.chromium.org/10443085/diff/1/src/factory.h File src/factory.h (right): http://codereview.chromium.org/10443085/diff/1/src/factory.h#newcode341 src/factory.h:341: Handle<String> EmergencyNewError(const char* type, Handle<JSArray> args); On 2012/05/31 08:48:52, ulan wrote:
Consider NewEmergencyError().
The error is normal, it's just happening at a bad moment, so I prefer the current name. http://codereview.chromium.org/10443085/diff/1/src/parser.h File src/parser.h (right): http://codereview.chromium.org/10443085/diff/1/src/parser.h#newcode452 src/parser.h:452: void EmergencyReportMessageAt(MessageLocation* location, On 2012/05/31 08:48:52, ulan wrote:
Dead code.
Done. http://codereview.chromium.org/10443085/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
