LGTM with comments.
https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.cc#newcode2826 src/jsregexp.cc:2826: offset, recursion_depth + 1, budget, bm, not_at_start); We either need to decrement the budget or add a comment why it is not necessary. https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.h File src/jsregexp.h (right): https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.h#newcode587 src/jsregexp.h:587: int budget, Please add a description for budget. https://chromiumcodereview.appspot.com/10448117/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
