https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1029
src/d8.cc:1029: void* data = ReadChars(*filename, &length);
On 2012/06/01 09:43:28, Michael Starzinger wrote:
Why this change? I would prefer it to stay "char*" if possible.

Actually, changed it to uint8_t, which is more adequate.

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1037
src/d8.cc:1037: persistent_buffer.MarkIndependent();
On 2012/06/01 09:43:28, Michael Starzinger wrote:
I think we are missing a positive adjustment of the external memory
amount
statistics here. The following line should do the trick.

V8::AdjustAmountOfExternalAllocatedMemory(length);

Done.

https://chromiumcodereview.appspot.com/10459047/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to