LGTM, but IMHO we can as well remove the whole assert...
http://codereview.chromium.org/10444136/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/10444136/diff/1/src/d8.cc#newcode1023 src/d8.cc:1023: ASSERT(sizeof(char) == sizeof(uint8_t)); // NOLINT sizeof(char) = 1 by definition, so I am not sure if we need the assertion at all. http://codereview.chromium.org/10444136/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
