Reviewers: ulan,
Description:
Fix grokdump inspector search for invalid addresses.
[email protected]
TEST=tools/grokdump.py
Please review this at https://chromiumcodereview.appspot.com/10467003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/grokdump.py
Index: tools/grokdump.py
diff --git a/tools/grokdump.py b/tools/grokdump.py
index
2227635d3fa6c9f6a4db75e04304eb212c20410a..a9f0cb9ddc282c5caab171f69f610720bf27bf15
100755
--- a/tools/grokdump.py
+++ b/tools/grokdump.py
@@ -1462,6 +1462,9 @@ class InspectionShell(cmd.Cmd):
for slot in xrange(start,
start + self.reader.PointerSize() * 10,
self.reader.PointerSize()):
+ if not self.reader.IsValidAddress(slot):
+ print "Address is not contained within the minidump!"
+ return
maybe_address = self.reader.ReadUIntPtr(slot)
heap_object = self.padawan.SenseObject(maybe_address)
print "%s: %s %s" % (self.reader.FormatIntPtr(slot),
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
