Revision: 11701 Author: [email protected] Date: Fri Jun 1 05:41:31 2012 Log: Fix grokdump inspector search for invalid addresses.
[email protected] TEST=tools/grokdump.py Review URL: https://chromiumcodereview.appspot.com/10467003 http://code.google.com/p/v8/source/detail?r=11701 Modified: /branches/bleeding_edge/tools/grokdump.py ======================================= --- /branches/bleeding_edge/tools/grokdump.py Thu May 31 01:01:54 2012 +++ /branches/bleeding_edge/tools/grokdump.py Fri Jun 1 05:41:31 2012 @@ -1462,6 +1462,9 @@ for slot in xrange(start, start + self.reader.PointerSize() * 10, self.reader.PointerSize()): + if not self.reader.IsValidAddress(slot): + print "Address is not contained within the minidump!" + return maybe_address = self.reader.ReadUIntPtr(slot) heap_object = self.padawan.SenseObject(maybe_address) print "%s: %s %s" % (self.reader.FormatIntPtr(slot), -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
