LGTM
https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assembler.h File src/regexp-macro-assembler.h (right): https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assembler.h#newcode187 src/regexp-macro-assembler.h:187: enum GlobalFlag { NOT_GLOBAL, GLOBAL, GLOBAL_NO_ZERO_LENGTH_MATCH }; I think GlobalMode would be better than GlobalFlag now that there are three states. And GLOBAL_NO_ZERO_LENGTH_CHECK better expresses what the macro assembler has to do (perform the check for zero length matches). https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assembler.h#newcode192 src/regexp-macro-assembler.h:192: inline bool global_with_zero_length_match() { global_with_zero_length_check() https://chromiumcodereview.appspot.com/10383280/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
