Reviewers: danno, Description: Fix bug in __proto__ assignment transition cache where we forget the next enumeration index resulting in wrong iteration order.
Please review this at https://chromiumcodereview.appspot.com/10515006/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects.cc A test/mjsunit/regress/regress-iteration-order.js Index: src/objects.cc =================================================================== --- src/objects.cc (revision 11705) +++ src/objects.cc (working copy) @@ -6040,6 +6040,7 @@ } } ASSERT(next_descriptor == new_descriptors->number_of_descriptors()); + new_descriptors->SetNextEnumerationIndex(NextEnumerationIndex()); return new_descriptors; } Index: test/mjsunit/regress/regress-iteration-order.js =================================================================== --- test/mjsunit/regress/regress-iteration-order.js (revision 0) +++ test/mjsunit/regress/regress-iteration-order.js (revision 0) @@ -0,0 +1,42 @@ +// Copyright 2012 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +var x = {a: 1, b: 2, c: 3}; + +x.__proto__ = {}; + +delete x.b; + +x.d = 4; + +s = ""; + +for (key in x) { + s += x[key]; +} + +assertEquals("134", s); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
