On 2012/06/05 09:13:24, Vyacheslav Egorov (Google) wrote:
https://chromiumcodereview.appspot.com/10538002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/10538002/diff/1/src/hydrogen-instructions.h#newcode4350
src/hydrogen-instructions.h:4350: class SkipCanonicalization: public
BitField<bool, 1, 2> {};
why not
bool is_dehoisted_ : 1;
bool skip_canonicalization_ : 1;
?
I personally have no preference and considered doing this initially, but
elsewhere in the code and in this file (CompareStub) we use BitField for
boolean
(I see no bool x : 1s), so I favored consistency.
https://chromiumcodereview.appspot.com/10538002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
