LGTM (with a few nits).
https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc#newcode2095 src/bootstrapper.cc:2095: Handle<SharedFunctionInfo> shared Move that below the compilation, or inline it into set_javascript_builtin_code completely. https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode12506 src/runtime.cc:12506: Handle<SharedFunctionInfo> shared(func->shared()); The shared function is no longer needed, just drop it. https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode12522 src/runtime.cc:12522: Handle<SharedFunctionInfo> shared(func->shared()); Likewise. https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode12526 src/runtime.cc:12526: shared->construct_stub()->PrintLn(); Just inline the func->shared() here. https://chromiumcodereview.appspot.com/10542002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
