Revision: 11721
Author: [email protected]
Date: Wed Jun 6 00:50:22 2012
Log: Remove CheckNotRegistersEqual regexp-masm function from all
architectures. This is a commit of
http://codereview.chromium.org/10066009/ for Daniel Kalmar
http://code.google.com/p/v8/source/detail?r=11721
Modified:
/branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc
/branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h
/branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc
/branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.h
/branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc
/branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.h
/branches/bleeding_edge/src/regexp-macro-assembler-irregexp.cc
/branches/bleeding_edge/src/regexp-macro-assembler-irregexp.h
/branches/bleeding_edge/src/regexp-macro-assembler-tracer.cc
/branches/bleeding_edge/src/regexp-macro-assembler-tracer.h
/branches/bleeding_edge/src/regexp-macro-assembler.h
/branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.cc
/branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.h
=======================================
--- /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc Mon Jun
4 01:49:17 2012
+++ /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc Wed Jun
6 00:50:22 2012
@@ -434,16 +434,6 @@
__ sub(current_input_offset(), r2, end_of_input_address());
__ bind(&fallthrough);
}
-
-
-void RegExpMacroAssemblerARM::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label* on_not_equal) {
- __ ldr(r0, register_location(reg1));
- __ ldr(r1, register_location(reg2));
- __ cmp(r0, r1);
- BranchOrBacktrack(ne, on_not_equal);
-}
void RegExpMacroAssemblerARM::CheckNotCharacter(unsigned c,
=======================================
--- /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h Tue May 22
07:05:44 2012
+++ /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h Wed Jun 6
00:50:22 2012
@@ -70,7 +70,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckNotCharacter(unsigned c, Label* on_not_equal);
virtual void CheckNotCharacterAfterAnd(unsigned c,
unsigned mask,
=======================================
--- /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc Mon
Jun 4 01:49:17 2012
+++ /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc Wed
Jun 6 00:50:22 2012
@@ -483,15 +483,6 @@
__ bind(&fallthrough);
}
-
-
-void RegExpMacroAssemblerIA32::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label* on_not_equal)
{
- __ mov(eax, register_location(reg1));
- __ cmp(eax, register_location(reg2));
- BranchOrBacktrack(not_equal, on_not_equal);
-}
void RegExpMacroAssemblerIA32::CheckNotCharacter(uint32_t c,
=======================================
--- /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.h Tue May
22 07:05:44 2012
+++ /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.h Wed Jun
6 00:50:22 2012
@@ -69,7 +69,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckNotCharacter(uint32_t c, Label* on_not_equal);
virtual void CheckNotCharacterAfterAnd(uint32_t c,
uint32_t mask,
=======================================
--- /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Thu May
24 01:09:21 2012
+++ /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Wed
Jun 6 00:50:22 2012
@@ -447,13 +447,6 @@
__ Subu(current_input_offset(), a2, end_of_input_address());
__ bind(&fallthrough);
}
-
-
-void RegExpMacroAssemblerMIPS::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label* on_not_equal)
{
- UNIMPLEMENTED_MIPS();
-}
void RegExpMacroAssemblerMIPS::CheckNotCharacter(uint32_t c,
=======================================
--- /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.h Thu May
24 00:29:49 2012
+++ /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.h Wed Jun
6 00:50:22 2012
@@ -72,7 +72,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckNotCharacter(uint32_t c, Label* on_not_equal);
virtual void CheckNotCharacterAfterAnd(uint32_t c,
uint32_t mask,
=======================================
--- /branches/bleeding_edge/src/regexp-macro-assembler-irregexp.cc Tue May
22 07:05:44 2012
+++ /branches/bleeding_edge/src/regexp-macro-assembler-irregexp.cc Wed Jun
6 00:50:22 2012
@@ -406,17 +406,6 @@
Emit(BC_CHECK_NOT_BACK_REF_NO_CASE, start_reg);
EmitOrLink(on_not_equal);
}
-
-
-void RegExpMacroAssemblerIrregexp::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label*
on_not_equal) {
- ASSERT(reg1 >= 0);
- ASSERT(reg1 <= kMaxRegister);
- Emit(BC_CHECK_NOT_REGS_EQUAL, reg1);
- Emit32(reg2);
- EmitOrLink(on_not_equal);
-}
void RegExpMacroAssemblerIrregexp::CheckCharacters(
=======================================
--- /branches/bleeding_edge/src/regexp-macro-assembler-irregexp.h Tue May
22 07:05:44 2012
+++ /branches/bleeding_edge/src/regexp-macro-assembler-irregexp.h Wed Jun
6 00:50:22 2012
@@ -103,7 +103,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckCharacters(Vector<const uc16> str,
int cp_offset,
Label* on_failure,
=======================================
--- /branches/bleeding_edge/src/regexp-macro-assembler-tracer.cc Tue May 22
07:05:44 2012
+++ /branches/bleeding_edge/src/regexp-macro-assembler-tracer.cc Wed Jun 6
00:50:22 2012
@@ -380,17 +380,6 @@
start_reg, LabelToInt(on_no_match));
assembler_->CheckNotBackReferenceIgnoreCase(start_reg, on_no_match);
}
-
-
-void RegExpMacroAssemblerTracer::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label*
on_not_equal) {
- PrintF(" CheckNotRegistersEqual(reg1=%d, reg2=%d, label[%08x]);\n",
- reg1,
- reg2,
- LabelToInt(on_not_equal));
- assembler_->CheckNotRegistersEqual(reg1, reg2, on_not_equal);
-}
void RegExpMacroAssemblerTracer::CheckCharacters(Vector<const uc16> str,
=======================================
--- /branches/bleeding_edge/src/regexp-macro-assembler-tracer.h Tue May 22
07:05:44 2012
+++ /branches/bleeding_edge/src/regexp-macro-assembler-tracer.h Wed Jun 6
00:50:22 2012
@@ -59,7 +59,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckNotCharacter(unsigned c, Label* on_not_equal);
virtual void CheckNotCharacterAfterAnd(unsigned c,
unsigned and_with,
=======================================
--- /branches/bleeding_edge/src/regexp-macro-assembler.h Mon Jun 4
01:49:17 2012
+++ /branches/bleeding_edge/src/regexp-macro-assembler.h Wed Jun 6
00:50:22 2012
@@ -128,10 +128,6 @@
// array, and if the found byte is non-zero, we jump to the on_bit_set
label.
virtual void CheckBitInTable(Handle<ByteArray> table, Label* on_bit_set)
= 0;
- virtual void CheckNotRegistersEqual(int reg1,
- int reg2,
- Label* on_not_equal) = 0;
-
// Checks whether the given offset from the current position is before
// the end of the string. May overwrite the current character.
virtual void CheckPosition(int cp_offset, Label* on_outside_input) {
=======================================
--- /branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.cc Mon Jun
4 01:49:17 2012
+++ /branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.cc Wed Jun
6 00:50:22 2012
@@ -525,15 +525,6 @@
__ bind(&fallthrough);
}
-
-
-void RegExpMacroAssemblerX64::CheckNotRegistersEqual(int reg1,
- int reg2,
- Label* on_not_equal) {
- __ movq(rax, register_location(reg1));
- __ cmpq(rax, register_location(reg2));
- BranchOrBacktrack(not_equal, on_not_equal);
-}
void RegExpMacroAssemblerX64::CheckNotCharacter(uint32_t c,
=======================================
--- /branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.h Wed May 23
04:36:54 2012
+++ /branches/bleeding_edge/src/x64/regexp-macro-assembler-x64.h Wed Jun 6
00:50:22 2012
@@ -66,7 +66,6 @@
virtual void CheckNotBackReference(int start_reg, Label* on_no_match);
virtual void CheckNotBackReferenceIgnoreCase(int start_reg,
Label* on_no_match);
- virtual void CheckNotRegistersEqual(int reg1, int reg2, Label*
on_not_equal);
virtual void CheckNotCharacter(uint32_t c, Label* on_not_equal);
virtual void CheckNotCharacterAfterAnd(uint32_t c,
uint32_t mask,
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
