LGTM with nits.
Medium-term, I want to move special handling of observed input
representations
from HBitwiseBinaryOperation to HBinaryOperation, but this is a good first
step.
https://chromiumcodereview.appspot.com/10540049/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/10540049/diff/3001/src/hydrogen.cc#newcode2217
src/hydrogen.cc:2217: // push information about values which
can't be converted to integer
nit: indentation
https://chromiumcodereview.appspot.com/10540049/diff/3001/src/hydrogen.cc#newcode2233
src/hydrogen.cc:2233: // sum up the non-phi use counts of all
connected phis.
nit: indentation
https://chromiumcodereview.appspot.com/10540049/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
