Reviewers: Michael Starzinger,

Message:
PTAL.


https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.status#newcode31
test/mjsunit/mjsunit.status:31: bugs/*: FAIL
Make it explicit that this is a wildcard matching rule.

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.status#newcode43
test/mjsunit/mjsunit.status:43: # regress/regress-524: (PASS ||
TIMEOUT), SKIP if $mode == debug
Duplicate definitions are bad (and unnecessary).

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mozilla/mozilla.status
File test/mozilla/mozilla.status (left):

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mozilla/mozilla.status#oldcode129
test/mozilla/mozilla.status:129: ecma/Date/15.9.5.29-1: PASS || (($ARM
|| $MIPS) && FAIL)
This syntax is uncommon, and the automatic syntax conversion I'm
planning would be unable to deal with it.

Description:
Clean up some minor stuff in test expectation files


Please review this at https://chromiumcodereview.appspot.com/10545082/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M test/mjsunit/mjsunit.status
  M test/mozilla/mozilla.status


Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index ab5f2e3e76fe14a524699fe78dd8c6c84c0ec066..47063faa9f6479842b085ab363258f51d721d135 100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -28,7 +28,7 @@
 prefix mjsunit

 # All tests in the bug directory are expected to fail.
-bugs: FAIL
+bugs/*: FAIL

##############################################################################
 # Fails.
@@ -38,6 +38,9 @@ regress/regress-1119: FAIL

 # NewGC: BUG(1719) slow to collect arrays over several contexts.
 regress/regress-524: SKIP
+# When that bug is fixed, revert the expectation to:
+# Skip long running test in debug and allow it to timeout in release mode.
+# regress/regress-524: (PASS || TIMEOUT), SKIP if $mode == debug

##############################################################################
 # Too slow in debug mode with --stress-opt
@@ -58,9 +61,6 @@ array-constructor: PASS || TIMEOUT
 # Very slow on ARM and MIPS, contains no architecture dependent code.
unicode-case-overoptimization: PASS, TIMEOUT if ($arch == arm || $arch == mips)

-# Skip long running test in debug and allow it to timeout in release mode.
-regress/regress-524: (PASS || TIMEOUT), SKIP if $mode == debug
-
 # Stack manipulations in LiveEdit are buggy - see bug 915
 debug-liveedit-check-stack: SKIP
 debug-liveedit-patch-positions-replace: SKIP
Index: test/mozilla/mozilla.status
diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status
index b83442484bf8fdd27027322cbf8237e18d1eb521..87d7bd29084a361b7d2dc3d5c6d2a157ae80b7da 100644
--- a/test/mozilla/mozilla.status
+++ b/test/mozilla/mozilla.status
@@ -126,13 +126,13 @@ ecma/Date/15.9.2.2-5: PASS || FAIL
 ecma/Date/15.9.2.2-6: PASS || FAIL

 # 1026139: These date tests fail on arm and mips
-ecma/Date/15.9.5.29-1: PASS || (($ARM || $MIPS) && FAIL)
-ecma/Date/15.9.5.34-1: PASS || (($ARM || $MIPS) && FAIL)
-ecma/Date/15.9.5.28-1: PASS || (($ARM || $MIPS) && FAIL)
+ecma/Date/15.9.5.29-1: PASS || FAIL if ($arch == arm || $arch == mips)
+ecma/Date/15.9.5.34-1: PASS || FAIL if ($arch == arm || $arch == mips)
+ecma/Date/15.9.5.28-1: PASS || FAIL if ($arch == arm || $arch == mips)

 # 1050186: Arm/MIPS vm is broken; probably unrelated to dates
-ecma/Array/15.4.4.5-3: PASS || (($ARM || $MIPS) && FAIL)
-ecma/Date/15.9.5.22-2: PASS || (($ARM || $MIPS) && FAIL)
+ecma/Array/15.4.4.5-3: PASS || FAIL if ($arch == arm || $arch == mips)
+ecma/Date/15.9.5.22-2: PASS || FAIL if ($arch == arm || $arch == mips)

 # Flaky test that fails due to what appears to be a bug in the test.
 # Occurs depending on current time


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to