LGTM with comments.
http://codereview.chromium.org/10532066/diff/4001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/10532066/diff/4001/src/ia32/lithium-codegen-ia32.cc#newcode215 src/ia32/lithium-codegen-ia32.cc:215: __ mov(Operand(ebp, JavaScriptFrameConstants::kLocal0Offset), edx); To reduce the theoretical expense of the tag in the non-dynamic_frame_alignment_ case, can you do the immediate store in a single instruction? http://codereview.chromium.org/10532066/diff/4001/src/ia32/lithium-codegen-ia32.cc#newcode2133 src/ia32/lithium-codegen-ia32.cc:2133: __ mov(edx, Operand(ebp, JavaScriptFrameConstants::kLocal0Offset)); Can you alias something like kFrameAlignmentCookieOffset to kLocalOffset and use it instead? http://codereview.chromium.org/10532066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
