LGTM
https://chromiumcodereview.appspot.com/10538102/diff/1/src/debug.cc File src/debug.cc (right): https://chromiumcodereview.appspot.com/10538102/diff/1/src/debug.cc#newcode2122 src/debug.cc:2122: has_break_points_ = true; As discussed offline, we can turn this to ASSERT(has_break_points); https://chromiumcodereview.appspot.com/10538102/diff/1/src/scopes.cc File src/scopes.cc (right): https://chromiumcodereview.appspot.com/10538102/diff/1/src/scopes.cc#newcode675 src/scopes.cc:675: bool Scope::AllowsLazyRecompilation() const { Now that it is the same as AllowsLazyCompilation, we can probably get rid of it. https://chromiumcodereview.appspot.com/10538102/diff/1/test/mjsunit/debug-script-breakpoints-nested.js File test/mjsunit/debug-script-breakpoints-nested.js (right): https://chromiumcodereview.appspot.com/10538102/diff/1/test/mjsunit/debug-script-breakpoints-nested.js#newcode49 test/mjsunit/debug-script-breakpoints-nested.js:49: " function b() {\n" + Consider adding more local variables. https://chromiumcodereview.appspot.com/10538102/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
