landed
http://codereview.chromium.org/10538104/diff/5001/src/elements.cc File src/elements.cc (right): http://codereview.chromium.org/10538104/diff/5001/src/elements.cc#newcode379 src/elements.cc:379: to_end = to_start + copy_size; On 2012/06/12 12:50:44, Jakob wrote:
I have a suspicion that the Windows compiler might wish for a static_cast<uint32_t>(copy_size) here (and again below).
Done. http://codereview.chromium.org/10538104/diff/5001/src/elements.cc#newcode425 src/elements.cc:425: if (hole_or_object == the_hole) { Yes :-) On 2012/06/12 12:50:44, Jakob wrote:
Why this change? Is it faster?
http://codereview.chromium.org/10538104/diff/5001/src/elements.cc#newcode625 src/elements.cc:625: bool is_packed = FLAG_packed_arrays && On 2012/06/12 12:50:44, Jakob wrote:
Another unnecessary FLAG check.
Done. http://codereview.chromium.org/10538104/diff/5001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10538104/diff/5001/src/objects.cc#newcode10026 src/objects.cc:10026: if (FLAG_packed_arrays && IsJSArray()) { On 2012/06/12 12:50:44, Jakob wrote:
This flag check isn't necessary, as we can't have PACKED elements
kinds without
the flag anyway. Same below.
Done. http://codereview.chromium.org/10538104/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
