Reviewers: ulan, Vyacheslav Egorov,
Description:
In test-api.cc a few calls to Heap::CollectAllGarbage use obsolete argument.
The assertion failure I ran into is in Regress1516, where collector falls
back
to SCAVENGER, during x64.debug.check run.
Zheng Liu
[email protected]
Please review this at http://codereview.chromium.org/10536199/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc (revision 11853)
+++ test/cctest/test-api.cc (working copy)
@@ -5242,7 +5242,7 @@
object.MarkIndependent();
HEAP->PerformScavenge();
CHECK(revived);
- HEAP->CollectAllGarbage(true);
+ HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
{
v8::HandleScope handle_scope;
v8::Local<String> y_str = v8_str("y");
@@ -9394,7 +9394,8 @@
v8::Handle<v8::Value> DirectApiCallback(const v8::Arguments& args) {
static int count = 0;
if (count++ % 3 == 0) {
- HEAP-> CollectAllGarbage(true); // This should move the stub
+ HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
+ // This should move the stub
GenerateSomeGarbage(); // This should ensure the old stub memory is
flushed
}
return v8::Handle<v8::Value>();
@@ -9449,7 +9450,7 @@
v8::Handle<v8::Value> DirectGetterCallback(Local<String> name,
const v8::AccessorInfo& info) {
if (++p_getter_count % 3 == 0) {
- HEAP->CollectAllGarbage(true);
+ HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
GenerateSomeGarbage();
}
return v8::Handle<v8::Value>();
@@ -16120,7 +16121,8 @@
CHECK_LE(1, elements);
}
- i::Isolate::Current()->heap()->CollectAllGarbage(true);
+ i::Isolate::Current()->heap()->CollectAllGarbage(
+ i::Heap::kAbortIncrementalMarkingMask);
{ i::Object* raw_map_cache =
i::Isolate::Current()->context()->map_cache();
if (raw_map_cache != i::Isolate::Current()->heap()->undefined_value())
{
i::MapCache* map_cache = i::MapCache::cast(raw_map_cache);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
