lgtm
http://codereview.chromium.org/10532193/diff/6001/src/array.js File src/array.js (right): http://codereview.chromium.org/10532193/diff/6001/src/array.js#newcode781 src/array.js:781: var t_array = []; Nah, it's fine. I'd rather have the readable code and know it's right. On 2012/06/19 18:36:29, Erik Corry wrote:
On 2012/06/19 14:52:17, danno wrote: > How about creating an InternalArray of the appropriate size here?
That
obviates > the need for the push() stub call later (you can just assign to the
element)
OK I tried that and it ended badly. I have to be 100% sure I get the
length
right and there are multiple chances to make off by 1 errors. Leaving
as it is
unless you feel very strongly about this.
http://codereview.chromium.org/10532193/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
