Rebased and comments addressed.
Also added a simple kBailoutOnMinusZero handling, please check it.
Apparently the "if(false)" in test should be enabled, but that would assert
on
arm.
On 2012/06/19 15:41:38, Yang wrote:
http://codereview.chromium.org/10382033/diff/7011/src/ia32/lithium-codegen-ia32.cc#newcode998
src/ia32/lithium-codegen-ia32.cc:998: // tedious because neg(dividend)
might
overflow
Comments should start with capital letter and end with a period.
Wouldn't neg only overflow for -2^31? Can't we simply deoptimize for this
case
and do a simple neg for the rest?
I thought that other Int32 ops don't easily deoptimize on kMinInt, so I'd
not
like to make it more fragile.
I'll change it if you do think it's too complex.
Thanks, Zheng Liu
[email protected]
http://codereview.chromium.org/10382033/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
