LGTM if you beef up your internal checking of state with some asserts.
https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h File src/property.h (right): https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode269 src/property.h:269: bool IsFastPropertyType() { return type() != NORMAL; } Add asserts for (IsFound()); https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode271 src/property.h:271: bool IsCallbacks() { return details_.type() == CALLBACKS; } Add asserts for (IsFound()); https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode278 src/property.h:278: bool IsField() { return details_.type() == FIELD; } Add asserts for (IsFound()); https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode279 src/property.h:279: bool IsNormal() { return details_.type() == NORMAL; } Add asserts for (IsFound()); https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode280 src/property.h:280: bool IsConstantFunction() { return details_.type() == CONSTANT_FUNCTION; } Add asserts for (IsFound()); https://chromiumcodereview.appspot.com/10626004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
