LGTM with comments.
https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode182 src/objects.h:182: enum StubType { How do you feel about moving this into the Code class? It would require inserting a bunch of "Code::" everywhere, but I think it'd be cleaner. In turn, you could probably remove the _STUB part of the values' names. https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode183 src/objects.h:183: NORMAL_STUB = 0, no need to explicitly define the values. https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode4567 src/objects.h:4567: class TypeField: public BitField<StubType, 3, 4> {}; You don't need 4 bits for an enum with 7 possible values. Please either reduce the BitField size to 3, or add a comment pointing out that there's a slack bit in there that can be reclaimed if it's needed for some other purpose. https://chromiumcodereview.appspot.com/10656018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
