LGTM (with a few final nits).
https://chromiumcodereview.appspot.com/10575032/diff/6001/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/10575032/diff/6001/src/ic.cc#newcode1942 src/ic.cc:1942: ASSERT(lookup->IsFound()); Add an empty line so that it looks consistent with StoreIC::UpdateCaches. https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.cc#newcode7364 src/objects.cc:7364: !heap->InNewSpace(elms)) { Since it's debug code now, I think we should just unconditionally zap, no matter how much we trim or in which space we trim. https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.cc#newcode7367 src/objects.cc:7367: zap++; // Header of filler must be at least one word so skip that. Using the same reasoning, I think we should also just zap the first word. https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.cc#newcode7390 src/objects.cc:7390: static bool ClearNonLiveTransitionsFromDescriptor(Heap* heap, Add a comment describing the semantics of the return value. https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10575032/diff/6001/src/objects.h#newcode4776 src/objects.h:4776: // store transitions, which does not contain any live transitions anymore. "[...] store transitions and does not [...]" https://chromiumcodereview.appspot.com/10575032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
