http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc File src/liveedit.cc (right):
http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc#newcode973 src/liveedit.cc:973: // there are pointers in case some of the objects move in a compacting GC. On 2012/06/25 11:43:51, Erik Corry wrote:
I think this comment should read:
// Perform a full GC in order to ensure that we are not in the middle
of an
incremental marking phase when we are replacing the code object.
Since we are
not in an incremental marking phase we can write pointers to code
objects (that
are never in new space) without worrying about write barriers.
Thank you! http://codereview.chromium.org/10639006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
