Reviewers: Jakob,

Description:
Disallow inlining of functions containing array literals.

This is disabled due to regressions in 3d-cube, but leaves the actual
code to allow inlining in place so it can easily be enabled again.

[email protected]
BUG=v8:1322


Please review this at https://chromiumcodereview.appspot.com/10690045/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ast.cc


Index: src/ast.cc
diff --git a/src/ast.cc b/src/ast.cc
index 8ac139fe85cca56263b2ea5b80d803baff69975a..52f452ba34abe0089c8223fec82137fc0930a6d8 100644
--- a/src/ast.cc
+++ b/src/ast.cc
@@ -1048,7 +1048,6 @@ REGULAR_NODE(Conditional)
 REGULAR_NODE(Literal)
 REGULAR_NODE(ObjectLiteral)
 REGULAR_NODE(RegExpLiteral)
-REGULAR_NODE(ArrayLiteral)
 REGULAR_NODE(Assignment)
 REGULAR_NODE(Throw)
 REGULAR_NODE(Property)
@@ -1078,6 +1077,7 @@ DONT_OPTIMIZE_NODE(TryFinallyStatement)
 DONT_OPTIMIZE_NODE(DebuggerStatement)
 DONT_OPTIMIZE_NODE(SharedFunctionInfoLiteral)

+DONT_INLINE_NODE(ArrayLiteral)  // TODO(1322): Allow materialized literals.
 DONT_INLINE_NODE(FunctionLiteral)

 DONT_SELFOPTIMIZE_NODE(DoWhileStatement)


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to