LGTM with nits.
I'd like it even more if instead of having the HCheckMaps we'd filter by
ElementsKinds (avoiding a deopt if a new map with one of the previously seen
ElementsKinds comes along), but I realize that's trickier than it sounds
because
of JSArray vs. JSObject.
http://chromiumcodereview.appspot.com/10692043/diff/4001/src/hydrogen.cc
File src/hydrogen.cc (right):
http://chromiumcodereview.appspot.com/10692043/diff/4001/src/hydrogen.cc#newcode5861
src/hydrogen.cc:5861: new(zone()) HCheckMaps(object, maps, zone());
nit: fits on one line
http://chromiumcodereview.appspot.com/10692043/diff/4001/src/hydrogen.cc#newcode5865
src/hydrogen.cc:5865: check_maps, most_general_consolidated_map, false);
nit: fits on the same line as "object, key, val".
http://chromiumcodereview.appspot.com/10692043/diff/4001/src/hydrogen.cc#newcode5949
src/hydrogen.cc:5949: : BuildLoadKeyedGeneric(object, key));
nit: why this change?
http://chromiumcodereview.appspot.com/10692043/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
