LGTM, with some nits.
https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-array-slice.js File test/mjsunit/typed-array-slice.js (right): https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-array-slice.js#newcode38 test/mjsunit/typed-array-slice.js:38: results4 = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; Could you declare all the above variables with 'var'? https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-array-slice.js#newcode49 test/mjsunit/typed-array-slice.js:49: for (i = 0; i < kElementCount; ++i ) { This could take a 'var', too. https://chromiumcodereview.appspot.com/10698069/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
