LGTM with nits.
https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc File src/v8threads.cc (right): https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc#newcode1 src/v8threads.cc:1: // Copyright 2008 the V8 project authors. All rights reserved. nit: 2012 https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc#newcode249 src/v8threads.cc:249: if (data_ != NULL) DeleteArray<char>(data_); I think we don't need the NULL check. https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.h File src/v8threads.h (right): https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.h#newcode1 src/v8threads.h:1: // Copyright 2008 the V8 project authors. All rights reserved. nit: 2012 https://chromiumcodereview.appspot.com/10702060/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
