https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode571 src/hydrogen.cc:571: Object* value) { On 2012/07/02 20:11:20, Michael Starzinger wrote:
Turn the second parameter into "Handle<Object> value"
Done. https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode583 src/hydrogen.cc:583: return GetConstant(&constant_1_, Smi::FromInt(1)); On 2012/07/02 20:11:20, Michael Starzinger wrote:
Use "Handle<Smi>(Smi::FromInt(1))" here.
Done. https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode588 src/hydrogen.cc:588: return GetConstant(&constant_minus1_, Smi::FromInt(-1)); On 2012/07/02 20:11:20, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode593 src/hydrogen.cc:593: return GetConstant(&constant_true_, isolate()->heap()->true_value()); On 2012/07/02 20:11:20, Michael Starzinger wrote:
Use "isolate->factory()->true_value()" here.
Done. https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode598 src/hydrogen.cc:598: return GetConstant(&constant_false_, isolate()->heap()->false_value()); On 2012/07/02 20:11:20, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcode605 src/hydrogen.cc:605: &isolate()->heap()->roots_array_start()[Heap::kTheHoleValueRootIndex]); On 2012/07/02 20:11:20, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10699052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
