LGTM with comment.
http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc#newcode1834 src/liveedit.cc:1834: return NULL; Could be shorter: if (result == NULL && target.saved_status() == [etc.]) { return [error message]; } return result; http://codereview.chromium.org/10693095/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
