Another round of drive-by comments.
https://chromiumcodereview.appspot.com/10697015/diff/8001/src/transitions-inl.h File src/transitions-inl.h (right): https://chromiumcodereview.appspot.com/10697015/diff/8001/src/transitions-inl.h#newcode175 src/transitions-inl.h:175: void TransitionArray::Set(int transition_number, String* key, Object* value) { This setter should take a WhitenessWitness as the last argument. This will require a slight generalization of that class, because it is no longer specific to the DescriptorArray. https://chromiumcodereview.appspot.com/10697015/diff/8001/src/transitions-inl.h#newcode178 src/transitions-inl.h:178: key); Actually I think it might be a good idea to pass the WhitenessWitness into NoIncrementalWriteBarrierSet() as well, to catch these cases statically. https://chromiumcodereview.appspot.com/10697015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
