Comments addressed. Landing.
https://chromiumcodereview.appspot.com/10703103/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10703103/diff/1/src/objects.cc#newcode2863 src/objects.cc:2863: // From this point on everything needs to be handlified, because On 2012/07/06 09:53:28, rossberg wrote:
Actually, the point is after the special handling of JSGlobalProxy,
which does a
recursive call into this same function again.
Done. https://chromiumcodereview.appspot.com/10703103/diff/1/src/objects.cc#newcode2865 src/objects.cc:2865: Handle<JSObject> object(this); On 2012/07/06 09:53:28, rossberg wrote:
Can we call it 'self', like in other places? That's a bit more
descriptive. Done. As discussed offline, in the long run this should be named "object" and passed in as the first argument to a completely handlified method. But as a interim solution I am fine with naming it "self" for now. https://chromiumcodereview.appspot.com/10703103/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
