Reviewers: danno, Jakob, Paul Lind, kisg,

Description:
MIPS: Rename "mips" arch to "mipsel" in the GYP build.

In the traditional MIPS naming scheme, "mips" is used for
big-endian mips and "mipsel" is used for little-endian mips.
In V8 the "mips" build is little-endian, so the "mips" target is
renamed to "mipsel" to be compliant with the traditional MIPS
naming scheme.

This change is also required for supporting the Chromium project on MIPS.

BUG=
TEST=


Please review this at https://chromiumcodereview.appspot.com/10695114/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M Makefile
  M build/common.gypi
  M build/standalone.gypi
  M tools/gyp/v8.gyp


Index: Makefile
diff --git a/Makefile b/Makefile
index d0cfd8139106c867758e577d46505f09a3bc0bc2..b963089bb229b02aa06970b05c83cf9d4b009873 100644
--- a/Makefile
+++ b/Makefile
@@ -118,7 +118,7 @@ endif

 # Architectures and modes to be compiled. Consider these to be internal
 # variables, don't override them (use the targets instead).
-ARCHES = ia32 x64 arm mips
+ARCHES = ia32 x64 arm mipsel
 DEFAULT_ARCHES = ia32 x64 arm
 MODES = release debug
 ANDROID_MODES = android.release android.debug
@@ -149,6 +149,10 @@ buildbot:
        $(MAKE) -C "$(OUTDIR)" BUILDTYPE=$(BUILDTYPE) \
                builddir="$(abspath $(OUTDIR))/$(BUILDTYPE)"

+mips mips.release mips.debug:
+       @echo "V8 does not support big-endian MIPS builds at the moment," \
+             "please use little-endian builds (mipsel)."
+
 # Compile targets. MODES and ARCHES are convenience targets.
 .SECONDEXPANSION:
 $(MODES): $(addsuffix .$$@,$(DEFAULT_ARCHES))
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a50ccbd57c513028e72284ff30e4d966254e4b76..523b56abe8e9ccf7186c496e1240c203d7e2d14a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -159,7 +159,7 @@
           'V8_TARGET_ARCH_IA32',
         ],
       }],  # v8_target_arch=="ia32"
-      ['v8_target_arch=="mips"', {
+      ['v8_target_arch=="mipsel"', {
         'defines': [
           'V8_TARGET_ARCH_MIPS',
         ],
@@ -214,7 +214,7 @@
             'defines': ['_MIPS_ARCH_LOONGSON',],
           }],
         ],
-      }],  # v8_target_arch=="mips"
+      }],  # v8_target_arch=="mipsel"
       ['v8_target_arch=="x64"', {
         'defines': [
           'V8_TARGET_ARCH_X64',
@@ -273,7 +273,7 @@
       ['(OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
          or OS=="netbsd" or OS=="mac" or OS=="android") and \
         (v8_target_arch=="arm" or v8_target_arch=="ia32" or \
-         v8_target_arch=="mips")', {
+         v8_target_arch=="mipsel")', {
         # Check whether the host compiler and target compiler support the
         # '-m32' option and set it if so.
         'target_conditions': [
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 72883ae4f83016384f6eb3dee57111e504dcd4d5..5e9291c38456bcf7ff76d8c9e9e7fe8d6eab97b1 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -67,7 +67,7 @@
     'werror%': '-Werror',
     'conditions': [
       ['(v8_target_arch=="arm" and host_arch!="arm") or \
-        (v8_target_arch=="mips" and host_arch!="mips") or \
+        (v8_target_arch=="mipsel" and host_arch!="mipsel") or \
         (v8_target_arch=="x64" and host_arch!="x64")', {
         'want_separate_host_toolset': 1,
       }, {
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 83b03f0af10fb5d87bc2b8b5924d88751633da67..8b5d1158cd2d9d271bdef6ab5eb51e464d41bf84 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -558,7 +558,7 @@
                 '../../src/ia32/stub-cache-ia32.cc',
               ],
             }],
-            ['v8_target_arch=="mips"', {
+            ['v8_target_arch=="mipsel"', {
               'sources': [
                 '../../src/mips/assembler-mips.cc',
                 '../../src/mips/assembler-mips.h',


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to