Addressed comments, PTAL.
https://chromiumcodereview.appspot.com/10692026/diff/9011/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10692026/diff/9011/src/mark-compact.cc#newcode1840 src/mark-compact.cc:1840: // to it. But make sure to skip back pointer and prototype transitions. On 2012/07/06 13:53:18, Michael Starzinger wrote:
Comment no longer applies, drop the "and prototype transitions".
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects-inl.h#newcode3563 src/objects-inl.h:3563: MaybeObject* Map::set_prototype_transitions(FixedArray* proto_transitions) { On 2012/07/06 13:53:18, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects-inl.h#newcode3568 src/objects-inl.h:3568: prototype_transitions() == proto_transitions) { On 2012/07/06 13:53:18, Michael Starzinger wrote:
I think this should actually be "!=" here. Maybe we should turn that
into an
assertion if it can actually never be "==" here.
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects-inl.h#newcode3626 src/objects-inl.h:3626: CONDITIONAL_WRITE_BARRIER( On 2012/07/06 13:53:18, Michael Starzinger wrote:
This should fit into one line now.
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects.h#newcode4810 src/objects.h:4810: inline void init_back_pointer(Object* undefined); As discussed offline, will leave as is. Not complex since only used while bootstrapping. On 2012/07/06 13:53:18, Michael Starzinger wrote:
Lets make that a camel-case method (i.e. InitializeBackPointer), since
it will
soon become more complex. Also drop the empty newline above.
https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects.h#newcode5002 src/objects.h:5002: static const int kBackPointerOffset = On 2012/07/06 13:53:18, Michael Starzinger wrote:
This should fit in one line now?
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/objects.h#newcode5004 src/objects.h:5004: static const int kPadStart = On 2012/07/06 13:53:18, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10692026/diff/9011/src/transitions.h File src/transitions.h (right): https://chromiumcodereview.appspot.com/10692026/diff/9011/src/transitions.h#newcode71 src/transitions.h:71: inline Object** GetPrototypeTransitionsSlot(); On 2012/07/06 13:53:18, Michael Starzinger wrote:
Can we group these accessors somehow, this is becoming a rather large
block. Done. https://chromiumcodereview.appspot.com/10692026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
